tools/json_schema_compiler/test/choices_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/choices_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/choices_unittest.cc

diff --git a/tools/json_schema_compiler/test/choices_unittest.cc b/tools/json_schema_compiler/test/choices_unittest.cc

index 159f10fb5fe6211be160bde56d242e96313588f5..5253cd95f89f7a8d34686fc20d1fdf375a1f8f21 100644

--- a/tools/json_schema_compiler/test/choices_unittest.cc

+++ b/tools/json_schema_compiler/test/choices_unittest.cc

@@ -18,8 +18,8 @@ using json_schema_compiler::test_util::Vector;

TEST(JsonSchemaCompilerChoicesTest, TakesIntegersParamsCreate) {

{

- scoped_ptr<TakesIntegers::Params> params(TakesIntegers::Params::Create(

- *List(base::Value::CreateBooleanValue(true))));

+ scoped_ptr<TakesIntegers::Params> params(

+ TakesIntegers::Params::Create(*List(new base::FundamentalValue(true))));

EXPECT_FALSE(params);

}

{