Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 397243003: Roll Clang 209387:213591

Created:
6 years, 5 months ago by hans
Modified:
6 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Roll Clang 209387:213591 Also bump the min os x version from 10.5 to 10.6 due to http://llvm.org/PR20212 BUG=381489

Patch Set 1 #

Patch Set 2 : Roll to Clang r213591 instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/clang/blink_gc_plugin/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hans
There is some redness from the try jobs. linux_rel_precise32: fails on the whitespace change too, ...
6 years, 5 months ago (2014-07-18 19:53:46 UTC) #1
Nico
lgtm, maybe say something in the cl description about the try jobs being unclear and ...
6 years, 5 months ago (2014-07-18 19:55:46 UTC) #2
hans
The CQ bit was checked by hans@chromium.org
6 years, 5 months ago (2014-07-18 20:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/397243003/1
6 years, 5 months ago (2014-07-18 20:04:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-19 00:26:33 UTC) #5
Nico
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/sync_file_system/drive_backend_v1/browser.api_util.o.d ... -c ../../chrome/browser/sync_file_system/drive_backend_v1/api_util.cc -o obj/chrome/browser/sync_file_system/drive_backend_v1/browser.api_util.o Assertion failed: (PhysReg != ...
6 years, 5 months ago (2014-07-19 00:28:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 01:26:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30657)
6 years, 5 months ago (2014-07-19 01:26:36 UTC) #8
Nico
I filed http://llvm.org/PR20367 for the crash. On Fri, Jul 18, 2014 at 6:26 PM, <commit-bot@chromium.org> ...
6 years, 5 months ago (2014-07-19 22:22:03 UTC) #9
hans
6 years, 5 months ago (2014-07-24 16:54:54 UTC) #10
New roll target is 213591. The try jobs look good except for the GC plugin
failure on the precise bot.

I'm not sure why it showed up only on that bot, but the failure should now have
been fixed by https://codereview.chromium.org/418803003. I'll start a new try
job.

Powered by Google App Engine
This is Rietveld 408576698