Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 418803003: Oilpan: fix WebSockets unit test GC plugin failure. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix WebSockets unit test GC plugin failure. The MockWebSocketChannelClient's trace() method must delegate to the mixin's trace() method (even if it is empty.) R=haraken@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/modules/websockets/NewWebSocketChannelImplTest.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look. (I haven't worked out where this started failing.)
6 years, 5 months ago (2014-07-24 08:22:52 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-24 08:24:50 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-24 08:36:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/418803003/1
6 years, 5 months ago (2014-07-24 08:38:00 UTC) #4
sof
On 2014/07/24 08:24:50, haraken wrote: > LGTM Thanks, sending this along, but there's a large ...
6 years, 5 months ago (2014-07-24 08:38:52 UTC) #5
commit-bot: I haz the power
Change committed as 178826
6 years, 5 months ago (2014-07-24 08:42:45 UTC) #6
sof
6 years, 5 months ago (2014-07-24 09:08:40 UTC) #7
Message was sent while issue was closed.
On 2014/07/24 08:38:52, sof wrote:
> On 2014/07/24 08:24:50, haraken wrote:
> > LGTM
> 
> Thanks, sending this along, but there's a large amount of unit test failures
> (leaks) with ToT.

Trying to address that in https://codereview.chromium.org/412173002/

Powered by Google App Engine
This is Rietveld 408576698