Add PPAPI interface for OpenGL ES 2.0 Vertex Array Objects.

Add PPAPI interface for OpenGL ES 2.0 Vertex Array Objects.

BUG=72612, 370496
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283750

[Zachary Kuznia, 2014-07-16 22:53:46]

Please take a look.

[nfullagar, 2014-07-16 23:02:28]

On 2014/07/16 22:53:46, Zachary Kuznia wrote:
> Please take a look.

thx for doing this - can you please add these issues to BUG:
  https://code.google.com/p/chromium/issues/detail?id=370496
  https://code.google.com/p/chromium/issues/detail?id=72612

[bbudge, 2014-07-16 23:04:40]

lgtm

[Zachary Kuznia, 2014-07-16 23:10:31]

On 2014/07/16 23:02:28, nfullagar wrote:
> On 2014/07/16 22:53:46, Zachary Kuznia wrote:
> > Please take a look.
> 
> thx for doing this - can you please add these issues to BUG:
>   https://code.google.com/p/chromium/issues/detail?id=370496
>   https://code.google.com/p/chromium/issues/detail?id=72612

Done.

[piman, 2014-07-16 23:32:40]

LGTM+a few nits. The name of the extension is because I worry we are not
managing the namespace very well, and we should start doing so if we're going to
expose more and more extensions. We can't change pepper interface names once we
ship them.

https://codereview.chromium.org/397183002/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/397183002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:1223: {'name': 'VertexArray',
'dev': False},
nit: mind calling it VertexArrayObject (which is closer to the name of the GL
extension)?

https://codereview.chromium.org/397183002/diff/1/ppapi/tests/test_graphics_3d.cc
File ppapi/tests/test_graphics_3d.cc (right):

https://codereview.chromium.org/397183002/diff/1/ppapi/tests/test_graphics_3d...
ppapi/tests/test_graphics_3d.cc:131: GLuint a_vertex_array;
nit: = 0

https://codereview.chromium.org/397183002/diff/1/ppapi/tests/test_graphics_3d...
ppapi/tests/test_graphics_3d.cc:132: GLboolean is_a_vertex_array;
nit: declare on first use

[Zachary Kuznia, 2014-07-17 04:41:28]

https://codereview.chromium.org/397183002/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/397183002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:1223: {'name': 'VertexArray',
'dev': False},
On 2014/07/16 23:32:40, piman (slow to review) wrote:
> nit: mind calling it VertexArrayObject (which is closer to the name of the GL
> extension)?

Done.

https://codereview.chromium.org/397183002/diff/1/ppapi/tests/test_graphics_3d.cc
File ppapi/tests/test_graphics_3d.cc (right):

https://codereview.chromium.org/397183002/diff/1/ppapi/tests/test_graphics_3d...
ppapi/tests/test_graphics_3d.cc:131: GLuint a_vertex_array;
On 2014/07/16 23:32:40, piman (slow to review) wrote:
> nit: = 0

Done.  Fixed the one above, too.

https://codereview.chromium.org/397183002/diff/1/ppapi/tests/test_graphics_3d...
ppapi/tests/test_graphics_3d.cc:132: GLboolean is_a_vertex_array;
On 2014/07/16 23:32:40, piman (slow to review) wrote:
> nit: declare on first use

Done.

[piman, 2014-07-17 05:15:12]

lgtm

[Zachary Kuznia, 2014-07-17 08:10:58]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-07-17 08:16:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zork@chromium.org/397183002/40001

[commit-bot: I haz the power, 2014-07-17 11:14:14]

Change committed as 283750