ServiceWorker: Bypass resolving a promise when ExecutionContext is gone

Source/modules/push_messaging/PushRegistration.h

Index: Source/modules/push_messaging/PushRegistration.h
diff --git a/Source/modules/push_messaging/PushRegistration.h b/Source/modules/push_messaging/PushRegistration.h
index b3865ee852a97cb5f06c12596ac8858c13449bfe..d46756f6d94262002adc8dce68213482eb9fcb38 100644
--- a/Source/modules/push_messaging/PushRegistration.h
+++ b/Source/modules/push_messaging/PushRegistration.h
@@ -24,6 +24,10 @@ public:
         OwnPtr<WebType> registration = adoptPtr(registrationRaw);
         return new PushRegistration(registration->endpoint, registration->registrationId);
     }
+    static void dispose(WebType* registrationRaw)

[Michael van Ouwerkerk, 2014/07/24 14:38:51]

Why is the dispose method inlined in PushRegistration, but not in PushError? It
seems inconsistent.

[nhiroki, 2014/07/24 15:52:32]

Moved from() & dispose() to *.cpp.

I meant to make consistent with from() which is also used for
CallbackPromiseAdapter.

+    {
+        delete registrationRaw;
+    }
 
     virtual ~PushRegistration();