LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html - Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close-expected.txt » ('j') | Source/modules/push_messaging/PushRegistration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html

diff --git a/LayoutTests/http/tests/serviceworker/window-close-during-registration.html b/LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html

similarity index 63%

copy from LayoutTests/http/tests/serviceworker/window-close-during-registration.html

copy to LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html

index 99a8c8d9ab6a6c0d4317e7b679582d2afefba150..76507590dbd10bb45d7c597e603728e5087faad3 100644

--- a/LayoutTests/http/tests/serviceworker/window-close-during-registration.html

+++ b/LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html

@@ -3,7 +3,7 @@

<body>

window.jsTestIsAsync = true;

-description('Test that closing the window during Service Worker registration does not assert or crash');

+description('Test that resolving a promise after the window gets closed does not assert or crash');

Michael van Ouwerkerk 2014/07/24 14:38:51 Could you add a similar test for Push Messaging?

nhiroki 2014/07/24 15:52:31 I couldn't find a place of layout tests for Push M

nhiroki 2014/07/24 15:55:33 Oops... sorry, I just found "WebKit/LayoutTests/pu

nhiroki 2014/07/24 16:35:52 Done.

if (window.testRunner) {

testRunner.setCanOpenWindows();

@@ -13,13 +13,11 @@ if (window.testRunner) {

}

function openWindow() {

- window.open('resources/window-close-during-registration.html');

+ window.open('resources/resolve-after-window-close.html');

}

function done() {

- setTimeout(function() {

- finishJSTest();

- }, 100);

+ finishJSTest();

}

</script>

</body>