Source/modules/push_messaging/PushError.cpp - Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushError.cpp

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html ('K') | « Source/modules/push_messaging/PushError.h ('k') | Source/modules/push_messaging/PushRegistration.h » ('j') | Source/modules/push_messaging/PushRegistration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushError.cpp

diff --git a/Source/modules/push_messaging/PushError.cpp b/Source/modules/push_messaging/PushError.cpp

index af263b0cf200509219531eab95bd838046fbaf63..49f14ec7d7fdc90d51cbe08a4078c42a29c08cc3 100644

--- a/Source/modules/push_messaging/PushError.cpp

+++ b/Source/modules/push_messaging/PushError.cpp

@@ -23,4 +23,9 @@ PassRefPtrWillBeRawPtr<DOMException> PushError::from(ScriptPromiseResolver*, Web

return DOMException::create(UnknownError);

}

+void PushError::dispose(WebType* webErrorRaw)

+ delete webErrorRaw;

} // namespace blink