Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/CallbackPromiseAdapter.h
diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h
index 417e0ebb1ff757de56f81bdc17675b2682639a6a..2e944234b8009a078ba4f306da70113648aa3cc0 100644
--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h
+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h
@@ -60,6 +60,13 @@ namespace blink {
// resolver->promise().then(...);
// }
//
+// // Called when aborting to resolve/reject a promise due to an empty
+// // execution context.
+// static void dispose(blink::WebMyClass* webInstance) {
+// // delete as appropriate, but often it's just:
+// delete webInstance;
+// }
+//
// Now when calling into a WebKit API that requires a WebCallbacks<blink::WebMyClass, blink::WebMyClass>*:
//
// // call signature: callSomeMethod(WebCallbacks<MyClass, MyClass>* callbacks)
@@ -74,17 +81,28 @@ public:
CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
{
+ ASSERT(m_resolver);
}
virtual ~CallbackPromiseAdapter() { }
virtual void onSuccess(typename S::WebType* result) OVERRIDE
{
+ if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
+ S::dispose(result);
+ return;
+ }
m_resolver->resolve(S::from(m_resolver.get(), result));
}
+
virtual void onError(typename T::WebType* error) OVERRIDE
{
+ if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
+ T::dispose(error);
+ return;
+ }
m_resolver->reject(T::from(m_resolver.get(), error));
}
+
private:
RefPtr<ScriptPromiseResolver> m_resolver;
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);

Powered by Google App Engine
This is Rietveld 408576698