LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html - Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close.html

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/chromium/resolve-after-window-close-expected.txt » ('j') | Source/modules/push_messaging/PushRegistration.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="/js-test-resources/js-test.js"></script>	2 <script src="/js-test-resources/js-test.js"></script>

3 <body>	3 <body>

4 <script>	4 <script>

5 window.jsTestIsAsync = true;	5 window.jsTestIsAsync = true;

6 description('Test that closing the window during Service Worker registration doe s not assert or crash');	6 description('Test that resolving a promise after the window gets closed does not assert or crash');
	Michael van Ouwerkerk 2014/07/24 14:38:51 Could you add a similar test for Push Messaging? Could you add a similar test for Push Messaging? nhiroki 2014/07/24 15:52:31 I couldn't find a place of layout tests for Push M Show quoted text On 2014/07/24 14:38:51, Michael van Ouwerkerk wrote: > Could you add a similar test for Push Messaging? I couldn't find a place of layout tests for Push Messaging. Where can I put the test? nhiroki 2014/07/24 15:55:33 Oops... sorry, I just found "WebKit/LayoutTests/pu Show quoted text On 2014/07/24 15:52:31, nhiroki wrote: > On 2014/07/24 14:38:51, Michael van Ouwerkerk wrote: > > Could you add a similar test for Push Messaging? > > I couldn't find a place of layout tests for Push Messaging. Where can I put the > test? Oops... sorry, I just found "WebKit/LayoutTests/push_messaging". I'll add a test. nhiroki 2014/07/24 16:35:52 Done. Show quoted text On 2014/07/24 15:55:33, nhiroki wrote: > On 2014/07/24 15:52:31, nhiroki wrote: > > On 2014/07/24 14:38:51, Michael van Ouwerkerk wrote: > > > Could you add a similar test for Push Messaging? > > > > I couldn't find a place of layout tests for Push Messaging. Where can I put > the > > test? > > Oops... sorry, I just found "WebKit/LayoutTests/push_messaging". I'll add a > test. Done.
7	7

8 if (window.testRunner) {	8 if (window.testRunner) {

9 testRunner.setCanOpenWindows();	9 testRunner.setCanOpenWindows();

10 openWindow();	10 openWindow();

11 } else {	11 } else {

12 document.write('<p>Click <a href="javascript:openWindow()">this link</a>. A window should open and close without asserting or crashing.</p>');	12 document.write('<p>Click <a href="javascript:openWindow()">this link</a>. A window should open and close without asserting or crashing.</p>');

13 }	13 }

14	14

15 function openWindow() {	15 function openWindow() {

16 window.open('resources/window-close-during-registration.html');	16 window.open('resources/resolve-after-window-close.html');

17 }	17 }

18	18

19 function done() {	19 function done() {

20 setTimeout(function() {	20 finishJSTest();

21 finishJSTest();

22 }, 100);

23 }	21 }

24 </script>	22 </script>

25 </body>	23 </body>

OLD	NEW