Restrict relocation packing to Release build.

Restrict relocation packing to Release build.

Pass CONFIGURATION_NAME as an argument to pack_arm_relocations.py, and
turn on packing only if its value is 'Release'.  (CONFIGURATION_NAME
cannot be used in conditionals because it is not resolved until after
the conditional has been processed.)

Prior art:
  https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/apk_obfuscate.py&l=103
  https://code.google.com/p/chromium/codesearch#chromium/src/build/java_apk.gypi&l=742

BUG=385553
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283721

[rmcilroy, 2014-07-16 15:24:04]

Adding Torne in case he has any better ideas about how to do this.

Please remove the "arm32" from description / summary since this change will
affect any architecture that has relocation packing enabled in the future.

I'll lgtm (with comments) now to unblock you since Torne is OOO.  If Torne has
any ideas when he gets back we can land a fix.

https://codereview.chromium.org/396283002/diff/1/build/android/gyp/pack_arm_r...
File build/android/gyp/pack_arm_relocations.py (right):

https://codereview.chromium.org/396283002/diff/1/build/android/gyp/pack_arm_r...
build/android/gyp/pack_arm_relocations.py:66: help='Gyp configuration name (i.e.
Debug, Release)')
Make a default value of Release, so that manual users of the tool don't get
confused if they pass --enable-packing=1 without a --configuration-name and
nothing happens.

https://codereview.chromium.org/396283002/diff/1/build/android/gyp/pack_arm_r...
build/android/gyp/pack_arm_relocations.py:69: help='Pack relocations if 1,
otherwise plain file copy')
Mention that --configuration-name needs to be Release for this to do anything.

[simonb (inactive), 2014-07-16 16:17:00]

Thanks.  Updates in patch set 2.

https://codereview.chromium.org/396283002/diff/1/build/android/gyp/pack_arm_r...
File build/android/gyp/pack_arm_relocations.py (right):

https://codereview.chromium.org/396283002/diff/1/build/android/gyp/pack_arm_r...
build/android/gyp/pack_arm_relocations.py:66: help='Gyp configuration name (i.e.
Debug, Release)')
On 2014/07/16 15:24:04, rmcilroy wrote:
> Make a default value of Release, so that manual users of the tool don't get
> confused if they pass --enable-packing=1 without a --configuration-name and
> nothing happens.

Done.

https://codereview.chromium.org/396283002/diff/1/build/android/gyp/pack_arm_r...
build/android/gyp/pack_arm_relocations.py:69: help='Pack relocations if 1,
otherwise plain file copy')
On 2014/07/16 15:24:03, rmcilroy wrote:
> Mention that --configuration-name needs to be Release for this to do anything.

Done.

[Torne, 2014-07-16 16:57:27]

Can't think of a better way to do this, it's probably ok. LGTM :)

[simonb (inactive), 2014-07-16 17:11:04]

The CQ bit was checked by simonb@chromium.org

[commit-bot: I haz the power, 2014-07-16 17:16:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonb@chromium.org/396283002/20001

[commit-bot: I haz the power, 2014-07-17 09:05:14]

Change committed as 283721