Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Side by Side Diff: build/android/pack_arm_relocations.gypi

Issue 396283002: Restrict relocation packing to Release build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/pack_arm_relocations.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file is meant to be included into an action to provide a rule that 5 # This file is meant to be included into an action to provide a rule that
6 # packs ARM relative relocations in native libraries. 6 # packs ARM relative relocations in Release builds of native libraries.
7 # 7 #
8 # To use this, create a gyp target with the following form: 8 # To use this, create a gyp target with the following form:
9 # { 9 # {
10 # 'action_name': 'pack_arm_relocations', 10 # 'action_name': 'pack_arm_relocations',
11 # 'actions': [ 11 # 'actions': [
12 # 'variables': { 12 # 'variables': {
13 # 'enable_packing': 'pack relocations if 1, plain file copy if 0' 13 # 'enable_packing': 'pack relocations if 1, plain file copy if 0'
14 # 'exclude_packing_list': 'names of libraries explicitly not packed', 14 # 'exclude_packing_list': 'names of libraries explicitly not packed',
15 # 'ordered_libraries_file': 'file generated by write_ordered_libraries' 15 # 'ordered_libraries_file': 'file generated by write_ordered_libraries'
16 # 'input_paths': 'files to be added to the list of inputs' 16 # 'input_paths': 'files to be added to the list of inputs'
(...skipping 22 matching lines...) Expand all
39 ['enable_packing == 1', { 39 ['enable_packing == 1', {
40 'message': 'Packing ARM relative relocations for <(_target_name)', 40 'message': 'Packing ARM relative relocations for <(_target_name)',
41 'dependencies': [ 41 'dependencies': [
42 '<(DEPTH)/tools/relocation_packer/relocation_packer.gyp:relocation_packe r#host', 42 '<(DEPTH)/tools/relocation_packer/relocation_packer.gyp:relocation_packe r#host',
43 ], 43 ],
44 'inputs': [ 44 'inputs': [
45 '<(PRODUCT_DIR)/relocation_packer', 45 '<(PRODUCT_DIR)/relocation_packer',
46 ], 46 ],
47 'action': [ 47 'action': [
48 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py', 48 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
49 '--configuration-name=<(CONFIGURATION_NAME)',
49 '--enable-packing=1', 50 '--enable-packing=1',
50 '--exclude-packing-list=<@(exclude_packing_list)', 51 '--exclude-packing-list=<@(exclude_packing_list)',
51 '--android-pack-relocations=<(PRODUCT_DIR)/relocation_packer', 52 '--android-pack-relocations=<(PRODUCT_DIR)/relocation_packer',
52 '--android-objcopy=<(android_objcopy)', 53 '--android-objcopy=<(android_objcopy)',
53 '--stripped-libraries-dir=<(stripped_libraries_dir)', 54 '--stripped-libraries-dir=<(stripped_libraries_dir)',
54 '--packed-libraries-dir=<(packed_libraries_dir)', 55 '--packed-libraries-dir=<(packed_libraries_dir)',
55 '--libraries-file=<(ordered_libraries_file)', 56 '--libraries-file=<(ordered_libraries_file)',
56 '--stamp=<(stamp)', 57 '--stamp=<(stamp)',
57 ], 58 ],
58 }, { 59 }, {
59 'message': 'Copying libraries (no relocation packing) for <(_target_name)' , 60 'message': 'Copying libraries (no relocation packing) for <(_target_name)' ,
60 'action': [ 61 'action': [
61 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py', 62 'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
63 '--configuration-name=<(CONFIGURATION_NAME)',
62 '--enable-packing=0', 64 '--enable-packing=0',
63 '--stripped-libraries-dir=<(stripped_libraries_dir)', 65 '--stripped-libraries-dir=<(stripped_libraries_dir)',
64 '--packed-libraries-dir=<(packed_libraries_dir)', 66 '--packed-libraries-dir=<(packed_libraries_dir)',
65 '--libraries-file=<(ordered_libraries_file)', 67 '--libraries-file=<(ordered_libraries_file)',
66 '--stamp=<(stamp)', 68 '--stamp=<(stamp)',
67 ], 69 ],
68 }], 70 }],
69 ['component == "shared_library"', { 71 ['component == "shared_library"', {
70 # Add a fake output to force the build to always re-run this step. This 72 # Add a fake output to force the build to always re-run this step. This
71 # is required because the real inputs are not known at gyp-time and 73 # is required because the real inputs are not known at gyp-time and
72 # changing base.so may not trigger changes to dependent libraries. 74 # changing base.so may not trigger changes to dependent libraries.
73 'outputs': [ '<(stamp).fake' ] 75 'outputs': [ '<(stamp).fake' ]
74 }], 76 }],
75 ], 77 ],
76 } 78 }
OLDNEW
« no previous file with comments | « build/android/gyp/pack_arm_relocations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698