Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3066)

Unified Diff: build/android/pack_arm_relocations.gypi

Issue 396283002: Restrict relocation packing to Release build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/pack_arm_relocations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pack_arm_relocations.gypi
diff --git a/build/android/pack_arm_relocations.gypi b/build/android/pack_arm_relocations.gypi
index 5a6589b138f32a50fa21e63bc5c58b3668026f0d..cb9a77b426aaade058c34a4d2e83099edab2954c 100644
--- a/build/android/pack_arm_relocations.gypi
+++ b/build/android/pack_arm_relocations.gypi
@@ -3,7 +3,7 @@
# found in the LICENSE file.
# This file is meant to be included into an action to provide a rule that
-# packs ARM relative relocations in native libraries.
+# packs ARM relative relocations in Release builds of native libraries.
#
# To use this, create a gyp target with the following form:
# {
@@ -46,6 +46,7 @@
],
'action': [
'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
+ '--configuration-name=<(CONFIGURATION_NAME)',
'--enable-packing=1',
'--exclude-packing-list=<@(exclude_packing_list)',
'--android-pack-relocations=<(PRODUCT_DIR)/relocation_packer',
@@ -59,6 +60,7 @@
'message': 'Copying libraries (no relocation packing) for <(_target_name)',
'action': [
'python', '<(DEPTH)/build/android/gyp/pack_arm_relocations.py',
+ '--configuration-name=<(CONFIGURATION_NAME)',
'--enable-packing=0',
'--stripped-libraries-dir=<(stripped_libraries_dir)',
'--packed-libraries-dir=<(packed_libraries_dir)',
« no previous file with comments | « build/android/gyp/pack_arm_relocations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698