Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 394833002: Ship ES6 Math functions. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -305 lines) Patch
M src/bootstrapper.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -2 lines 0 comments Download
D src/harmony-math.js View 1 chunk +0 lines, -246 lines 0 comments Download
M src/math.js View 2 chunks +231 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +23 lines, -24 lines 0 comments Download
M test/mjsunit/es6/math-cbrt.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-clz32.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/math-expm1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/math-fround.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-hyperbolic.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-hypot.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-log1p.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-log2-log10.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-sign.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-trunc.js View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-15 14:54:29 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-07-16 09:46:30 UTC) #2
Yang
6 years, 5 months ago (2014-07-16 14:00:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698