Close the password bubble on the icon click.

chrome/browser/ui/views/location_bar/bubble_icon_view.h

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
index 8133b0ffbcaff29557a162b54571f20800b412e9..6981d7a612701767ac076ef24a928ac9168f2195 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
@@ -38,6 +38,10 @@ class BubbleIconView : public views::ImageView {
   // ui::EventHandler:
   virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
 
+  bool suppress_mouse_released_action() const {

[Peter Kasting, 2014/07/23 17:58:23]

Rather than add this, we could do the following, which seems cleaner:

* Move IsBubbleShowing() to ManagePasswordsIconView
* Simplify the definition of BubbleIconView::OnMousePressed() to not check
IsBubbleShowing(); instead, change ManagePasswordsIconView::OnMousePressed() to
check that and handle that appropriately
* Simplify the definition of BubbleIconView::GetTooltipText() to not check
IsBubbleShowing(); instead, override GetTooltipText() in
ManagePasswordsIconView() to check that and call the superclass method if it's
false.

Basically, this removes any knowledge of the manage passwords bubble from this
class, and keeps it all in the subclass.

Sorry for not thinking of this sooner.

[vasilii, 2014/07/24 15:43:18]

I didn't get your proposal. BubbleIconView is used by other bubbles too and for
them it's important that we don't show the tooltip and ignore the click if the
bubble is open. I don't want to copy/paste the same code into all the
subclasses.
Anyway I got rid of this method.

+    return suppress_mouse_released_action_;
+  }
+
  private:
   // The CommandUpdater for the Browser object that owns the location bar.
   CommandUpdater* command_updater_;