Close the password bubble on the icon click.

chrome/browser/ui/views/location_bar/bubble_icon_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
 
 #include "ui/views/controls/image_view.h"
 
 class CommandUpdater;
@@ skipping 20 matching lines @@
   virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;
   virtual bool GetTooltipText(const gfx::Point& p, base::string16* tooltip)
       const OVERRIDE;
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
   virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
 
   // ui::EventHandler:
   virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
 
+  bool suppress_mouse_released_action() const {

[Peter Kasting, 2014/07/23 17:58:23]

Rather than add this, we could do the following, which seems cleaner:

* Move IsBubbleShowing() to ManagePasswordsIconView
* Simplify the definition of BubbleIconView::OnMousePressed() to not check
IsBubbleShowing(); instead, change ManagePasswordsIconView::OnMousePressed() to
check that and handle that appropriately
* Simplify the definition of BubbleIconView::GetTooltipText() to not check
IsBubbleShowing(); instead, override GetTooltipText() in
ManagePasswordsIconView() to check that and call the superclass method if it's
false.

Basically, this removes any knowledge of the manage passwords bubble from this
class, and keeps it all in the subclass.

Sorry for not thinking of this sooner.

[vasilii, 2014/07/24 15:43:18]

I didn't get your proposal. BubbleIconView is used by other bubbles too and for
them it's important that we don't show the tooltip and ignore the click if the
bubble is open. I don't want to copy/paste the same code into all the
subclasses.
Anyway I got rid of this method.

+    return suppress_mouse_released_action_;
+  }
+
  private:
   // The CommandUpdater for the Browser object that owns the location bar.
   CommandUpdater* command_updater_;
 
   // The command ID executed when the user clicks this icon.
   const int command_id_;
 
   // This is used to check if the bookmark bubble was showing during the mouse
   // pressed event. If this is true then the mouse released event is ignored to
   // prevent the bubble from reshowing.
   bool suppress_mouse_released_action_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleIconView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_