Close the password bubble on the icon click.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 356919e43c008c9ec0c899d2b20ca244aa3204db..f40910b47b2dba943761ac8a15655d603aeed644 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -126,6 +126,9 @@ void AddTitleRow(views::GridLayout* layout, ManagePasswordsBubbleModel* model) {
 namespace chrome {
 
 void ShowManagePasswordsBubble(content::WebContents* web_contents) {
+  if (ManagePasswordsBubbleView::IsShowing()) {

[Peter Kasting, 2014/07/23 17:58:23]

Nit: No {}

You might want a brief note about why we want to close the bubble here.

[vasilii, 2014/07/24 15:43:18]

Done.

+    ManagePasswordsBubbleView::CloseBubble();
+  }
   ManagePasswordsUIController* controller =
       ManagePasswordsUIController::FromWebContents(web_contents);
   ManagePasswordsBubbleView::ShowBubble(
@@ -434,11 +437,6 @@ ManagePasswordsBubbleView* ManagePasswordsBubbleView::manage_passwords_bubble_ =
     NULL;
 
 // static
-const ManagePasswordsBubbleView* ManagePasswordsBubbleView::Bubble() {
-  return ManagePasswordsBubbleView::manage_passwords_bubble_;
-}
-
-// static
 void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
                                            DisplayReason reason) {
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
@@ -493,6 +491,11 @@ bool ManagePasswordsBubbleView::IsShowing() {
       manage_passwords_bubble_->GetWidget()->IsVisible();
 }
 
+// static
+const ManagePasswordsBubbleView* ManagePasswordsBubbleView::Bubble() {
+  return ManagePasswordsBubbleView::manage_passwords_bubble_;

[Peter Kasting, 2014/07/23 17:58:23]

Nit: This is a simple getter, so it should probably be inlined into the header
and named "bubble()".

[vasilii, 2014/07/24 15:43:18]

Done.

+}
+
 ManagePasswordsBubbleView::ManagePasswordsBubbleView(
     content::WebContents* web_contents,
     ManagePasswordsIconView* anchor_view,