Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 394053003: QUIC - minor cleanup changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index ba8000c5681503253b35e6aa948cdb9d330a036b..9d44754a3c5d0fd9baac24b8e35eb226f7b4f694 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -106,7 +106,7 @@ void QuicCryptoClientStream::OnHandshakeMessage(
// |message| is an update from the server, so we treat it differently from a
// handshake message.
- HandleServerConfigUpdateMessage(&message);
+ HandleServerConfigUpdateMessage(message);
return;
}
@@ -136,13 +136,13 @@ bool QuicCryptoClientStream::WasChannelIDSent() const {
}
void QuicCryptoClientStream::HandleServerConfigUpdateMessage(
- const CryptoHandshakeMessage* in) {
- DCHECK(in->tag() == kSCUP);
+ const CryptoHandshakeMessage& in) {
wtc 2014/07/16 20:42:46 Nit: please name the input "server_config_update".
ramant (doing other things) 2014/07/16 22:31:40 Done.
+ DCHECK(in.tag() == kSCUP);
string error_details;
QuicCryptoClientConfig::CachedState* cached =
crypto_config_->LookupOrCreate(server_id_);
QuicErrorCode error = crypto_config_->ProcessServerConfigUpdate(
- *in,
+ in,
session()->connection()->clock()->WallNow(),
cached,
&crypto_negotiated_params_,

Powered by Google App Engine
This is Rietveld 408576698