net/quic/quic_crypto_client_stream.h - Issue 394053003: QUIC - minor cleanup changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_crypto_client_stream.h

Issue 394053003: QUIC - minor cleanup changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_crypto_client_stream.h

diff --git a/net/quic/quic_crypto_client_stream.h b/net/quic/quic_crypto_client_stream.h

index 7250547f3878b57bb822c397821e9b151969fa68..5ebb9b90323c0d80a33f299615821201472f3511 100644

--- a/net/quic/quic_crypto_client_stream.h

+++ b/net/quic/quic_crypto_client_stream.h

@@ -106,7 +106,7 @@ class NET_EXPORT_PRIVATE QuicCryptoClientStream : public QuicCryptoStream {

// Handles new server config and optional source-address token provided by the

// server during a connection.

- void HandleServerConfigUpdateMessage(const CryptoHandshakeMessage* in);

+ void HandleServerConfigUpdateMessage(const CryptoHandshakeMessage& in);

wtc 2014/07/16 20:42:47 Nit: please name the input "server_config_update".

ramant (doing other things) 2014/07/16 22:31:40 Done.

// DoHandshakeLoop performs a step of the handshake state machine. Note that

// |in| may be NULL if the call did not result from a received message.