QUIC - minor cleanup changes.

net/quic/quic_crypto_client_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_crypto_client_stream.h"
 
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/quic/crypto/crypto_utils.h"
 #include "net/quic/crypto/null_encrypter.h"
 #include "net/quic/quic_client_session_base.h"
@@ skipping 88 matching lines @@
   QuicCryptoStream::OnHandshakeMessage(message);
 
   if (message.tag() == kSCUP) {
     if (!handshake_confirmed()) {
       CloseConnection(QUIC_CRYPTO_UPDATE_BEFORE_HANDSHAKE_COMPLETE);
       return;
     }
 
     // |message| is an update from the server, so we treat it differently from a
     // handshake message.
-    HandleServerConfigUpdateMessage(&message);
+    HandleServerConfigUpdateMessage(message);
     return;
   }
 
   // Do not process handshake messages after the handshake is confirmed.
   if (handshake_confirmed()) {
     CloseConnection(QUIC_CRYPTO_MESSAGE_AFTER_HANDSHAKE_COMPLETE);
     return;
   }
 
   DoHandshakeLoop(&message);
 }
 
 bool QuicCryptoClientStream::CryptoConnect() {
   next_state_ = STATE_INITIALIZE;
   DoHandshakeLoop(NULL);
   return true;
 }
 
 int QuicCryptoClientStream::num_sent_client_hellos() const {
   return num_client_hellos_;
 }
 
 bool QuicCryptoClientStream::WasChannelIDSent() const {
   // TODO(rch): we should replace this with a boolean member so we
   // can free the memory associated with the key after we're finished with it.
   return channel_id_key_.get() != NULL;
 }
 
 void QuicCryptoClientStream::HandleServerConfigUpdateMessage(
-    const CryptoHandshakeMessage* in) {
-  DCHECK(in->tag() == kSCUP);
+    const CryptoHandshakeMessage& in) {

[wtc, 2014/07/16 20:42:46]

Nit: please name the input "server_config_update".

[ramant (doing other things), 2014/07/16 22:31:40]

Done.

+  DCHECK(in.tag() == kSCUP);
   string error_details;
   QuicCryptoClientConfig::CachedState* cached =
       crypto_config_->LookupOrCreate(server_id_);
   QuicErrorCode error = crypto_config_->ProcessServerConfigUpdate(
-      *in,
+      in,
       session()->connection()->clock()->WallNow(),
       cached,
       &crypto_negotiated_params_,
       &error_details);
 
   if (error != QUIC_NO_ERROR) {
     CloseConnectionWithDetails(
         error, "Server config update invalid: " + error_details);
     return;
   }
@@ skipping 336 matching lines @@
     }
   }
   return false;
 }
 
 QuicClientSessionBase* QuicCryptoClientStream::client_session() {
   return reinterpret_cast<QuicClientSessionBase*>(session());
 }
 
 }  // namespace net