Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: tools/perf/measurements/thread_times.py

Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split Start into SetUp and Start for smoothness and timeline controller. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/smoothness_unittest.py ('k') | tools/perf/measurements/timeline_controller.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/thread_times.py
diff --git a/tools/perf/measurements/thread_times.py b/tools/perf/measurements/thread_times.py
index 2940c86489ad49b96db88db7bca25148fb6126fa..e653f8e314ed184691ace0be588024a38c71c180 100644
--- a/tools/perf/measurements/thread_times.py
+++ b/tools/perf/measurements/thread_times.py
@@ -22,7 +22,7 @@ class ThreadTimes(page_measurement.PageMeasurement):
def results_are_the_same_on_every_page(self):
return False
- def WillRunActions(self, page, tab):
+ def WillNavigateToPage(self, page, tab):
self._timeline_controller = timeline_controller.TimelineController()
if self.options.report_silk_details:
# We need the other traces in order to have any details to report.
@@ -31,7 +31,10 @@ class ThreadTimes(page_measurement.PageMeasurement):
else:
self._timeline_controller.trace_categories = \
tracing_backend.MINIMAL_TRACE_CATEGORIES
- self._timeline_controller.Start(page, tab)
+ self._timeline_controller.SetUp(page, tab)
+
+ def WillRunActions(self, page, tab):
+ self._timeline_controller.Start(tab)
def DidRunActions(self, page, tab):
self._timeline_controller.Stop(tab)
« no previous file with comments | « tools/perf/measurements/smoothness_unittest.py ('k') | tools/perf/measurements/timeline_controller.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698