Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/perf/measurements/timeline_controller.py

Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split Start into SetUp and Start for smoothness and timeline controller. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/timeline_controller.py
diff --git a/tools/perf/measurements/timeline_controller.py b/tools/perf/measurements/timeline_controller.py
index 77d39341e871ffcfb19080634eb1a2265a9c53eb..4cd0008b27de9fea89ba7ebe66f8e1593da1855e 100644
--- a/tools/perf/measurements/timeline_controller.py
+++ b/tools/perf/measurements/timeline_controller.py
@@ -21,7 +21,7 @@ class TimelineController(object):
self._smooth_records = []
self._interaction = None
- def Start(self, page, tab):
+ def SetUp(self, page, tab):
"""Starts gathering timeline data.
"""
@@ -36,6 +36,8 @@ class TimelineController(object):
else:
categories = page.GetSyntheticDelayCategories()
tab.browser.StartTracing(','.join(categories))
+
+ def Start(self, tab):
# Start the smooth marker for all actions.
runner = action_runner.ActionRunner(tab)
self._interaction = runner.BeginInteraction(
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698