tools/perf/measurements/smoothness_unittest.py - Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split Start into SetUp and Start for smoothness and timeline controller. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness_unittest.py

diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py

index e537399237661481f02e767b04604c9ba982a614..6c59d51b55d3ffb6d1198949512e97ab698152bd 100644

--- a/tools/perf/measurements/smoothness_unittest.py

+++ b/tools/perf/measurements/smoothness_unittest.py

@@ -61,6 +61,7 @@ class SmoothnessUnitTest(

tab = FakeTab()

measurement = smoothness.Smoothness()

measurement.WillStartBrowser(tab.browser)

+ measurement.WillNavigateToPage(test_page, tab)

measurement.WillRunActions(test_page, tab)

expected_category_filter = [

« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »