Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h - Issue 392583003: [SVG] Make metrics passed to calculateGlyphAdvanceAndOrientation const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h

Issue 392583003: [SVG] Make metrics passed to calculateGlyphAdvanceAndOrientation const (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h

diff --git a/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h b/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h

index 3a4de2308d5174d01b479be7501f0073bb50ae78..d99c128c0e564bafc0da7b2a3e7b12105406d612 100644

--- a/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h

+++ b/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h

@@ -40,7 +40,7 @@ public:

float calculateBaselineShift(const SVGRenderStyle&, SVGElement* lengthContext) const;

float calculateAlignmentBaselineShift(bool isVerticalText, const RenderObject* textRenderer) const;

float calculateGlyphOrientationAngle(bool isVerticalText, const SVGRenderStyle&, const UChar& character) const;

- float calculateGlyphAdvanceAndOrientation(bool isVerticalText, SVGTextMetrics&, float angle, float& xOrientationShift, float& yOrientationShift) const;

+ float calculateGlyphAdvanceAndOrientation(bool isVerticalText, const SVGTextMetrics&, float angle, float& xOrientationShift, float& yOrientationShift) const;

private:

EAlignmentBaseline dominantBaselineToAlignmentBaseline(bool isVerticalText, const RenderObject* textRenderer) const;

« no previous file with comments | « no previous file | Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp » ('j') | no next file with comments »