Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp - Issue 392583003: [SVG] Make metrics passed to calculateGlyphAdvanceAndOrientation const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

Issue 392583003: [SVG] Make metrics passed to calculateGlyphAdvanceAndOrientation const (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

diff --git a/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp b/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

index 03182fa665692fc97255747849dd55d57097486a..3c08b305b88d4e23e6a77199f67d39664fed5635 100644

--- a/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

+++ b/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

@@ -178,7 +178,7 @@ static inline bool glyphOrientationIsMultiplyOf180Degrees(float orientationAngle

return !fabsf(fmodf(orientationAngle, 180));

}

-float SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation(bool isVerticalText, SVGTextMetrics& metrics, float angle, float& xOrientationShift, float& yOrientationShift) const

+float SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation(bool isVerticalText, const SVGTextMetrics& metrics, float angle, float& xOrientationShift, float& yOrientationShift) const

{

bool orientationIsMultiplyOf180Degrees = glyphOrientationIsMultiplyOf180Degrees(angle);

« no previous file with comments | « Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h ('k') | no next file » | no next file with comments »