Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 392373002: [safe browsing] Mobile requests different malware and phishing lists. (Closed)

Created:
6 years, 5 months ago by Scott Hess - ex-Googler
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[safe browsing] Mobile requests different malware and phishing lists. Also stores results in a different store. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284834

Patch Set 1 #

Patch Set 2 : Change hard-coded default lists for Android tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -61 lines) Patch
M chrome/browser/safe_browsing/database_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 10 chunks +41 lines, -21 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 1 8 chunks +58 lines, -31 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/location_bar/origin_chip_info.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Scott Hess - ex-Googler
I am trying to clean up how things are configured separately, and then we can ...
6 years, 5 months ago (2014-07-16 17:14:38 UTC) #1
Feng Qian
lgtm
6 years, 5 months ago (2014-07-17 20:38:19 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 5 months ago (2014-07-17 20:43:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/392373002/1
6 years, 5 months ago (2014-07-17 20:46:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 01:00:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 01:23:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172219)
6 years, 5 months ago (2014-07-18 01:23:34 UTC) #7
Scott Hess - ex-Googler
Tests failed on Android for the obvious reason that the expectations hard-coded the list names. ...
6 years, 5 months ago (2014-07-18 18:25:40 UTC) #8
Feng Qian
lgtm
6 years, 5 months ago (2014-07-18 21:08:18 UTC) #9
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-18 22:01:29 UTC) #10
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 5 months ago (2014-07-18 22:09:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/392373002/20001
6 years, 5 months ago (2014-07-18 22:10:40 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 01:27:39 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 05:24:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/40819)
6 years, 5 months ago (2014-07-19 05:24:40 UTC) #15
Scott Hess - ex-Googler
On 2014/07/19 05:24:40, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-22 21:53:18 UTC) #16
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 5 months ago (2014-07-22 21:53:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/392373002/20001
6 years, 5 months ago (2014-07-22 21:55:56 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 02:03:38 UTC) #19
Message was sent while issue was closed.
Change committed as 284834

Powered by Google App Engine
This is Rietveld 408576698