[safe browsing] Mobile requests different malware and phishing lists.

chrome/browser/safe_browsing/protocol_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 18 matching lines @@
 namespace {
 
 const char kUrlPrefix[] = "https://prefix.com/foo";
 const char kBackupConnectUrlPrefix[] = "https://alt1-prefix.com/foo";
 const char kBackupHttpUrlPrefix[] = "https://alt2-prefix.com/foo";
 const char kBackupNetworkUrlPrefix[] = "https://alt3-prefix.com/foo";
 const char kClient[] = "unittest";
 const char kAppVer[] = "1.0";
 const char kAdditionalQuery[] = "additional_query";
 
+#if defined(OS_ANDROID)
+const char kDefaultPhishList[] = "goog-mobilephish-shavar";
+const char kDefaultMalwareList[] = "goog-mobilemalware-shavar";
+#else
+const char kDefaultPhishList[] = "goog-phish-shavar";
+const char kDefaultMalwareList[] = "goog-malware-shavar";
+#endif
+
 // Add-prefix chunk with single prefix.
 const char kRawChunkPayload1[] = {
   '\0', '\0', '\0', '\x08',  // 32-bit payload length in network byte order.
   '\x08',                    // field 1, wire format varint
   '\x03',                    // chunk_number varint 3
   '\x22',                    // field 4, wire format length-delimited
   '\x04',                    // varint 4 length
   'a', 'b', 'c', 'd'         // 4-byte prefix
 };
 const std::string kChunkPayload1(kRawChunkPayload1, sizeof(kRawChunkPayload1));
@@ skipping 38 matching lines @@
 #endif
     return scoped_ptr<SafeBrowsingProtocolManager>(
         SafeBrowsingProtocolManager::Create(delegate, NULL, config));
   }
 
   void ValidateUpdateFetcherRequest(
       const net::TestURLFetcher* url_fetcher,
       const std::string& expected_prefix) {
     ASSERT_TRUE(url_fetcher);
     EXPECT_EQ(net::LOAD_DISABLE_CACHE, url_fetcher->GetLoadFlags());
-    EXPECT_EQ("goog-phish-shavar;\ngoog-malware-shavar;\n",
-              url_fetcher->upload_data());
+
+    std::string expected_lists(base::StringPrintf("%s;\n%s;\n",
+                                                  kDefaultPhishList,
+                                                  kDefaultMalwareList));
+    EXPECT_EQ(expected_lists, url_fetcher->upload_data());
     EXPECT_EQ(GURL(expected_prefix + "/downloads?client=unittest&appver=1.0"
                    "&pver=3.0" + key_param_),
               url_fetcher->GetOriginalURL());
   }
 
   void ValidateUpdateFetcherRequest(const net::TestURLFetcher* url_fetcher) {
     ValidateUpdateFetcherRequest(url_fetcher, kUrlPrefix);
   }
 
   void ValidateRedirectFetcherRequest(const net::TestURLFetcher* url_fetcher,
@@ skipping 52 matching lines @@
 
   // Received a successful response.
   next = pm->GetNextUpdateInterval(false);
   EXPECT_EQ(next, TimeDelta::FromSeconds(1800));
 }
 
 TEST_F(SafeBrowsingProtocolManagerTest, TestChunkStrings) {
   scoped_ptr<SafeBrowsingProtocolManager> pm(CreateProtocolManager(NULL));
 
   // Add and Sub chunks.
-  SBListChunkRanges phish("goog-phish-shavar");
+  SBListChunkRanges phish(kDefaultPhishList);
   phish.adds = "1,4,6,8-20,99";
   phish.subs = "16,32,64-96";
-  EXPECT_EQ("goog-phish-shavar;a:1,4,6,8-20,99:s:16,32,64-96\n",
+  EXPECT_EQ(base::StringPrintf("%s;a:1,4,6,8-20,99:s:16,32,64-96\n",
+                               kDefaultPhishList),
             safe_browsing::FormatList(phish));
 
   // Add chunks only.
   phish.subs = "";
-  EXPECT_EQ("goog-phish-shavar;a:1,4,6,8-20,99\n",
+  EXPECT_EQ(base::StringPrintf("%s;a:1,4,6,8-20,99\n",
+                               kDefaultPhishList),
             safe_browsing::FormatList(phish));
 
   // Sub chunks only.
   phish.adds = "";
   phish.subs = "16,32,64-96";
-  EXPECT_EQ("goog-phish-shavar;s:16,32,64-96\n",
+  EXPECT_EQ(base::StringPrintf("%s;s:16,32,64-96\n",
+                               kDefaultPhishList),
             safe_browsing::FormatList(phish));
 
   // No chunks of either type.
   phish.adds = "";
   phish.subs = "";
-  EXPECT_EQ("goog-phish-shavar;\n", safe_browsing::FormatList(phish));
+  EXPECT_EQ(base::StringPrintf("%s;\n", kDefaultPhishList),
+            safe_browsing::FormatList(phish));
 }
 
 TEST_F(SafeBrowsingProtocolManagerTest, TestGetHashBackOffTimes) {
   scoped_ptr<SafeBrowsingProtocolManager> pm(CreateProtocolManager(NULL));
 
   // No errors or back off time yet.
   EXPECT_EQ(0U, pm->gethash_error_count_);
   EXPECT_TRUE(pm->next_gethash_time_.is_null());
 
   Time now = Time::Now();
@@ skipping 209 matching lines @@
       CreateProtocolManager(&test_delegate));
 
   // Kick off initialization. This returns chunks from the DB synchronously.
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // We should have an URLFetcher at this point in time.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ASSERT_TRUE(url_fetcher);
   EXPECT_EQ(net::LOAD_DISABLE_CACHE, url_fetcher->GetLoadFlags());
-  EXPECT_EQ("goog-phish-shavar;a:adds_phish:s:subs_phish\n"
-            "unknown_list;a:adds_unknown:s:subs_unknown\n"
-            "goog-malware-shavar;\n",
+  EXPECT_EQ(base::StringPrintf("%s;a:adds_phish:s:subs_phish\n"
+                               "unknown_list;a:adds_unknown:s:subs_unknown\n"
+                               "%s;\n",
+                               kDefaultPhishList, kDefaultMalwareList),
             url_fetcher->upload_data());
   EXPECT_EQ(GURL("https://prefix.com/foo/downloads?client=unittest&appver=1.0"
                  "&pver=3.0" + key_param_),
             url_fetcher->GetOriginalURL());
 
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(200);
   url_fetcher->SetResponseString(std::string());
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
@@ skipping 486 matching lines @@
   // Kick off initialization. This returns chunks from the DB synchronously.
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // The update response contains a single redirect command.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(200);
   url_fetcher->SetResponseString(
-      "i:goog-phish-shavar\n"
-      "u:redirect-server.example.com/path\n");
+      base::StringPrintf("i:%s\n"
+                         "u:redirect-server.example.com/path\n",
+                         kDefaultPhishList));
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // The redirect response contains an empty body.
   net::TestURLFetcher* chunk_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateRedirectFetcherRequest(
       chunk_url_fetcher, "https://redirect-server.example.com/path");
   chunk_url_fetcher->set_status(net::URLRequestStatus());
   chunk_url_fetcher->set_response_code(200);
   chunk_url_fetcher->SetResponseString(std::string());
@@ skipping 24 matching lines @@
   // Kick off initialization. This returns chunks from the DB synchronously.
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // The update response contains a single redirect command.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(200);
   url_fetcher->SetResponseString(
-      "i:goog-phish-shavar\n"
-      "u:redirect-server.example.com/path\n");
+      base::StringPrintf("i:%s\n"
+                         "u:redirect-server.example.com/path\n",
+                         kDefaultPhishList));
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // The redirect response contains an invalid body.
   net::TestURLFetcher* chunk_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateRedirectFetcherRequest(
       chunk_url_fetcher, "https://redirect-server.example.com/path");
   chunk_url_fetcher->set_status(net::URLRequestStatus());
   chunk_url_fetcher->set_response_code(200);
   chunk_url_fetcher->SetResponseString("THIS IS AN INVALID RESPONSE");
   chunk_url_fetcher->delegate()->OnURLFetchComplete(chunk_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests a single valid update response, followed by a single redirect response
 // containing chunks.
 TEST_F(SafeBrowsingProtocolManagerTest, SingleRedirectResponseWithChunks) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
   base::ThreadTaskRunnerHandle runner_handler(runner);
   net::TestURLFetcherFactory url_fetcher_factory;
 
   testing::StrictMock<MockProtocolDelegate> test_delegate;
   EXPECT_CALL(test_delegate, UpdateStarted()).Times(1);
   EXPECT_CALL(test_delegate, GetChunks(_)).WillOnce(
       Invoke(testing::CreateFunctor(InvokeGetChunksCallback,
                                     std::vector<SBListChunkRanges>(),
                                     false)));
-  EXPECT_CALL(test_delegate, AddChunksRaw("goog-phish-shavar", _, _)).WillOnce(
+  EXPECT_CALL(test_delegate, AddChunksRaw(kDefaultPhishList, _, _)).WillOnce(
       Invoke(HandleAddChunks));
   EXPECT_CALL(test_delegate, UpdateFinished(true)).Times(1);
 
   scoped_ptr<SafeBrowsingProtocolManager> pm(
       CreateProtocolManager(&test_delegate));
 
   // Kick off initialization. This returns chunks from the DB synchronously.
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // The update response contains a single redirect command.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(200);
   url_fetcher->SetResponseString(
-      "i:goog-phish-shavar\n"
-      "u:redirect-server.example.com/path\n");
+      base::StringPrintf("i:%s\n"
+                         "u:redirect-server.example.com/path\n",
+                         kDefaultPhishList));
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // The redirect response contains a single chunk.
   net::TestURLFetcher* chunk_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateRedirectFetcherRequest(
       chunk_url_fetcher, "https://redirect-server.example.com/path");
   chunk_url_fetcher->set_status(net::URLRequestStatus());
   chunk_url_fetcher->set_response_code(200);
   chunk_url_fetcher->SetResponseString(kChunkPayload1);
@@ skipping 14 matching lines @@
       new base::TestSimpleTaskRunner());
   base::ThreadTaskRunnerHandle runner_handler(runner);
   net::TestURLFetcherFactory url_fetcher_factory;
 
   testing::StrictMock<MockProtocolDelegate> test_delegate;
   EXPECT_CALL(test_delegate, UpdateStarted()).Times(1);
   EXPECT_CALL(test_delegate, GetChunks(_)).WillOnce(
       Invoke(testing::CreateFunctor(InvokeGetChunksCallback,
                                     std::vector<SBListChunkRanges>(),
                                     false)));
-  EXPECT_CALL(test_delegate, AddChunksRaw("goog-phish-shavar", _, _)).
+  EXPECT_CALL(test_delegate, AddChunksRaw(kDefaultPhishList, _, _)).
       WillRepeatedly(Invoke(HandleAddChunks));
   EXPECT_CALL(test_delegate, UpdateFinished(true)).Times(1);
 
   scoped_ptr<SafeBrowsingProtocolManager> pm(
       CreateProtocolManager(&test_delegate));
 
   // Kick off initialization. This returns chunks from the DB synchronously.
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // The update response contains multiple redirect commands.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(200);
   url_fetcher->SetResponseString(
-      "i:goog-phish-shavar\n"
-      "u:redirect-server.example.com/one\n"
-      "u:redirect-server.example.com/two\n");
+      base::StringPrintf("i:%s\n"
+                         "u:redirect-server.example.com/one\n"
+                         "u:redirect-server.example.com/two\n",
+                         kDefaultPhishList));
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // The first redirect response contains a single chunk.
   net::TestURLFetcher* first_chunk_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateRedirectFetcherRequest(
       first_chunk_url_fetcher, "https://redirect-server.example.com/one");
   first_chunk_url_fetcher->set_status(net::URLRequestStatus());
   first_chunk_url_fetcher->set_response_code(200);
   first_chunk_url_fetcher->SetResponseString(kChunkPayload1);
@@ skipping 16 matching lines @@
   second_chunk_url_fetcher->delegate()->OnURLFetchComplete(
       second_chunk_url_fetcher);
 
   EXPECT_FALSE(pm->IsUpdateScheduled());
 
   // Invoke the AddChunksCallback to finish the update.
   runner->RunPendingTasks();
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }