Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.cc

Issue 392373002: [safe browsing] Mobile requests different malware and phishing lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change hard-coded default lists for Android tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.cc b/chrome/browser/safe_browsing/safe_browsing_database.cc
index 7c7f688a064be47baa382eb2b9d95288aa5b6fa0..07f674c9e2289593260ebd4b7312857ece1323de 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database.cc
@@ -64,7 +64,17 @@ const base::FilePath::CharType kIPBlacklistDBFile[] =
// for little benefit. If/when file formats change (say to put all
// the data in one file), that would be a convenient point to rectify
// this.
+// TODO(shess): This shouldn't be OS-driven <http://crbug.com/394379>
+#if defined(OS_ANDROID)
+// NOTE(shess): This difference is also reflected in the list name in
+// safe_browsing_util.cc.
+// TODO(shess): Spin up an alternate list id which can be persisted in the
+// store. Then if a mistake is made, it won't cause confusion between
+// incompatible lists.
+const base::FilePath::CharType kBrowseDBFile[] = FILE_PATH_LITERAL(" Mobile");
+#else
const base::FilePath::CharType kBrowseDBFile[] = FILE_PATH_LITERAL(" Bloom");
+#endif
// Maximum number of entries we allow in any of the whitelists.
// If a whitelist on disk contains more entries then all lookups to
« no previous file with comments | « chrome/browser/safe_browsing/protocol_parser_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_tab_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698