Make GrCacheable implement its own ref counting.

Make GrCacheable implement its own ref counting.

Committed: https://skia.googlesource.com/skia/+/dcabb05113a732636691abc16d643a091336aea5

[bsalomon, 2014-07-21 20:14:46]

https://codereview.chromium.org/392333008/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (left):

https://codereview.chromium.org/392333008/diff/20001/src/gpu/GrContext.cpp#ol...
src/gpu/GrContext.cpp:531: } else if (texture->getDeferredRefCount() <= 0) {
I think this is safe because incDeferredRefCount() was never called before this
CL, so the count was always 0.

https://codereview.chromium.org/392333008/diff/20001/src/gpu/GrContext.cpp#ol...
src/gpu/GrContext.cpp:557: } else if (texture->unique() &&
texture->getDeferredRefCount() <= 0) {
I'm not sure I did the right thing here. Maybe I should have just removed the
check of deferred ref cnt in the if clause and left everything else.

[robertphillips, 2014-07-21 20:53:05]

lgtm (modulo 1 fixup)

https://codereview.chromium.org/392333008/diff/20001/include/gpu/GrCacheable.h
File include/gpu/GrCacheable.h (right):

https://codereview.chromium.org/392333008/diff/20001/include/gpu/GrCacheable....
include/gpu/GrCacheable.h:19: public:
This macro call needs to go (along with those in all derived classes). There is
a matching macro in the .cpp files too.

https://codereview.chromium.org/392333008/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (left):

https://codereview.chromium.org/392333008/diff/20001/src/gpu/GrContext.cpp#ol...
src/gpu/GrContext.cpp:557: } else if (texture->unique() &&
texture->getDeferredRefCount() <= 0) {
I think we want to remove the check of deferred ref cnt on the middle block and
remove the third block. Just like above.

[bsalomon, 2014-07-21 21:05:14]

updated as discussed live.

[bsalomon, 2014-07-21 21:10:49]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-07-21 21:11:16]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/392333008/60001

[commit-bot: I haz the power, 2014-07-21 21:24:08]

Change committed as dcabb05113a732636691abc16d643a091336aea5