Fix flipped views on Mac

Fix flipped views on Mac

Setting a layer-hosting NSView's CALayer's geometry flipping has a lot
of unexpected side-effects, and is proving unsafe, especially if that
NSView will have sub-views.

Add a level of indirection where the hosted layer is not flipped, but it
has a sub-layer that is flipped, off of which the layers for composited
content are attached.

BUG=392952
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283862

[ccameron, 2014-07-16 03:11:02]

This ends up being a simpler way to solve the problem. It appears that messing
with flipping for a layer-hosted NSView's CALayer is just unsafe.

It ends up being fairly difficult to not create the child NSView (the option we
were discussing), because the RenderWidgetHostViewCocoa is accessed in
platform-independent code. Also, the BrowserCompositorViewMac is also a child
NSView (without the layering violations), with all of the related issues.

[Andre, 2014-07-16 17:16:38]

On 2014/07/16 03:11:02, ccameron1 wrote:
> This ends up being a simpler way to solve the problem. It appears that messing
> with flipping for a layer-hosted NSView's CALayer is just unsafe.
> 
> It ends up being fairly difficult to not create the child NSView (the option
we
> were discussing), because the RenderWidgetHostViewCocoa is accessed in
> platform-independent code. Also, the BrowserCompositorViewMac is also a child
> NSView (without the layering violations), with all of the related issues.

lgtm.
I"m not familiar with this part of the code, but I don't see any problem.
Maybe add comment about why flipping is needed (because of remote layer resizing
that happens in another process)?

[ccameron, 2014-07-16 17:49:01]

Added the comment above declaration of flipped_layer_. 

Adding myself to OWNERS as well, and adding piman to check the OWNERS change
(the change is Cocoa/CoreAnimation stuff that is better with a Mac reviewer).

[piman, 2014-07-16 17:54:30]

lgtm

[ccameron, 2014-07-16 18:27:30]

Thanks!

[ccameron, 2014-07-16 18:27:33]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-16 18:31:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/40001

[commit-bot: I haz the power, 2014-07-16 21:46:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-16 23:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:03:43]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[ccameron, 2014-07-16 23:39:27]

On 2014/07/16 23:03:43, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

Ugh, the update to the resizing code caused a house of cards to collapse. In
particular, adding the NSView for the browser compositor is changing which view
gets focus, and is blowing up some of the interactive_ui_tests. I'm updating the
code to adding the CALayers for the browser compositor directly to the
RenderWidgetHostViewCocoa's hierarchy instead (we may want to revisit this WRT
views code in the future ... for now, this seems much more reliable).

[ccameron, 2014-07-17 01:56:31]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-17 02:00:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/60001

[commit-bot: I haz the power, 2014-07-17 05:07:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29438)

[commit-bot: I haz the power, 2014-07-17 05:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 05:13:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29482)

[ccameron, 2014-07-17 06:03:42]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-17 06:10:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/60001

[commit-bot: I haz the power, 2014-07-17 06:16:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29527)

[commit-bot: I haz the power, 2014-07-17 06:22:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 06:22:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29530)

[ccameron, 2014-07-17 07:23:32]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-17 07:26:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/60001

[commit-bot: I haz the power, 2014-07-17 07:31:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29561)

[commit-bot: I haz the power, 2014-07-17 07:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 07:33:48]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29563)

[ccameron, 2014-07-17 08:59:18]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-17 09:01:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/60001

[commit-bot: I haz the power, 2014-07-17 09:06:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29621)

[commit-bot: I haz the power, 2014-07-17 09:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 09:09:21]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29624)

[ccameron, 2014-07-17 17:23:08]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:25:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/60001

[ccameron, 2014-07-17 17:32:14]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:33:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/392143002/80001

[commit-bot: I haz the power, 2014-07-17 20:42:50]

Change committed as 283862