Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: content/browser/compositor/browser_compositor_view_private_mac.h

Issue 392143002: Fix flipped views on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rwhelper_monstrosity
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/browser_compositor_view_private_mac.h
diff --git a/content/browser/compositor/browser_compositor_view_private_mac.h b/content/browser/compositor/browser_compositor_view_private_mac.h
index a6e998cf9e228c39b2ebc041dcf11976459d9197..c1b3fdbed1e3dbeb7278a32db7f89adee8cddee9 100644
--- a/content/browser/compositor/browser_compositor_view_private_mac.h
+++ b/content/browser/compositor/browser_compositor_view_private_mac.h
@@ -17,10 +17,19 @@ class BrowserCompositorViewCocoaHelper;
@interface BrowserCompositorViewCocoa : NSView {
scoped_ptr<ui::Compositor> compositor_;
- base::scoped_nsobject<CALayer> background_layer_;
+ // A flipped layer, which acts as the parent of the compositing and software
+ // layers. This layer is flipped so that the we don't need to recompute the
+ // origin for sub-layers when their position changes (this is impossible when
+ // using remote layers, as their size change cannot be synchronized with the
+ // window). This indirection is needed because flipping hosted layers (like
+ // |background_layer_| of RenderWidgetHostViewCocoa) leads to unpredictable
+ // behavior.
+ base::scoped_nsobject<CALayer> flipped_layer_;
+
base::scoped_nsobject<CompositingIOSurfaceLayer> accelerated_layer_;
int accelerated_layer_output_surface_id_;
std::vector<ui::LatencyInfo> accelerated_latency_info_;
+
base::scoped_nsobject<SoftwareLayer> software_layer_;
content::BrowserCompositorViewMacClient* client_;
« no previous file with comments | « content/browser/compositor/OWNERS ('k') | content/browser/compositor/browser_compositor_view_private_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698