Delete trace-info.json.

Delete trace-info.json.

Not read any more after cl/71194379.

BUG=389114
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286701

[sullivan, 2014-07-15 19:18:29]

lgtm

[nduca, 2014-07-15 19:33:18]

not lgtm.

instead, please add a description= to telemetry/value.py that stores the
description on the value object. Then update all call sites in telemetry for
these strings to include descriptions. E.g. dont lose the data!!!!

[qyearsley, 2014-07-15 20:20:30]

On 2014/07/15 19:33:18, nduca wrote:
> not lgtm.
> 
> instead, please add a description= to telemetry/value.py that stores the
> description on the value object. Then update all call sites in telemetry for
> these strings to include descriptions. E.g. dont lose the data!!!!

Alright -- I was originally thinking that this might be done separately, and
that the data is still accessible at
http://src.chromium.org/viewvc/chrome/trunk/src/tools/perf/trace-info.json?pa....

But I agree that it would be good to put those descriptions into the individual
tests along with the same CL that deletes this file, so I won't submit this CL
until it includes those changes as well.

(Note: I think that when I was talking with Tony and Ethan earlier, we mentioned
that benchmark/"test suite" descriptions might be extracted from docstrings, but
for individual values, we'll want to specify description with a named parameter,
correct?)

[qyearsley, 2014-07-29 21:49:26]

I have now moved the descriptions into the individual
metrics/measurements/benchmarks.

For the memory metrics, I removed "...for the ... process" from the descriptions
because it was simpler that way and process type is in the value name.

There were some descriptions for traces that are either not reported anymore or
are not reported by Telemetry benchmarks, including:
"average_latency", "average_num_layers_drawn", "avg_surface_fps",
"dropped_percent", "percent_impl_scrolled", "texture_upload_count",
"total_texture_upload_time".

PTAL.

[nduca, 2014-07-30 09:34:59]

i think you're missing the metrics in tools/telemetry/web_perf .... mean frame
time i think is in there. assuming you sort that down, lgtm

[qyearsley, 2014-07-30 17:13:11]

On 2014/07/30 09:34:59, nduca wrote:
> i think you're missing the metrics in tools/telemetry/web_perf .... mean frame
> time i think is in there. assuming you sort that down, lgtm

Alright, I added those and then noticed that the values that are added currently
in smoothness_controller seem to come ultimately from
pylib.perf.surface_stats_collector, so I changed the descriptions added there.

There are obviously still lots of descriptions missing (for most values), but
those can be added in the future when updating/changing metrics/measurements.

[qyearsley, 2014-07-30 17:13:17]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-07-30 17:14:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qyearsley@chromium.org/391183002/60001

[tonyg, 2014-07-30 17:18:30]

belated lgtm -- woot!

[tonyg, 2014-07-30 17:19:40]

BTW, are we going to get overall benchmark descriptions from pydocs?

[qyearsley, 2014-07-30 17:33:21]

On 2014/07/30 17:19:40, tonyg wrote:
> BTW, are we going to get overall benchmark descriptions from pydocs?

Good question --

I think for overall benchmark descriptions we'll may want to output them in the
top-level of the output JSON; presumably they'll be gotten from
benchmark_class.Description(), the same way that descriptions are gotten for
"run_benchmark list"? Made a note about this in the doc:
https://docs.google.com/a/google.com/document/d/1HZv6v5hFPpey5N2DsjQ0KEIvR8B-...

One note about this CL is that it doesn't have any effect yet because none of
the Telemetry output formats output description... but when Ethan makes the JSON
Telemetry output mode (which I think will call value.AsDict), the trace
descriptions should be in there.

[commit-bot: I haz the power, 2014-07-30 21:08:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-31 03:13:13]

Change committed as 286701