Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: tools/perf/measurements/smoothness_controller.py

Issue 391183002: Delete trace-info.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed descriptions in smoothness_controller. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/metrics/iometric.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness_controller.py
diff --git a/tools/perf/measurements/smoothness_controller.py b/tools/perf/measurements/smoothness_controller.py
index 6e8dcd9acead0a809ee674bad59ede024a9cec59..b29a1edda5c75953925564a8640737a20515c65e 100644
--- a/tools/perf/measurements/smoothness_controller.py
+++ b/tools/perf/measurements/smoothness_controller.py
@@ -15,6 +15,12 @@ from telemetry.web_perf.metrics import smoothness
RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'
+# Descriptions for results from platform.GetRawDisplayFrameRateMeasurements().
+DESCRIPTIONS = {
+ 'avg_surface_fps': 'Average frames per second as measured by the '
+ 'platform\'s SurfaceFlinger.'
+}
+
class MissingDisplayFrameRateError(page_measurement.MeasurementFailure):
def __init__(self, name):
@@ -90,7 +96,7 @@ class SmoothnessController(object):
smooth_records = [run_smooth_actions_record]
# Create an interaction_record for this legacy measurement. Since we don't
- # wrap the results that is sent to smoothnes metric, the label will
+ # wrap the results that are sent to smoothness metric, the label will
# not be used.
smoothness_metric = smoothness.SmoothnessMetric()
smoothness_metric.AddResults(
@@ -101,10 +107,12 @@ class SmoothnessController(object):
raise MissingDisplayFrameRateError(r.name)
if isinstance(r.value, list):
results.AddValue(list_of_scalar_values.ListOfScalarValues(
- results.current_page, r.name, r.unit, r.value))
+ results.current_page, r.name, r.unit, r.value,
+ description=DESCRIPTIONS.get(r.name)))
else:
results.AddValue(scalar.ScalarValue(
- results.current_page, r.name, r.unit, r.value))
+ results.current_page, r.name, r.unit, r.value,
+ description=DESCRIPTIONS.get(r.name)))
def CleanUp(self, tab):
if tab.browser.platform.IsRawDisplayFrameRateSupported():
« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/metrics/iometric.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698