tools/perf/measurements/page_cycler.py - Issue 391183002: Delete trace-info.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 391183002: Delete trace-info.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed descriptions in smoothness_controller. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index 5316986f0522ca5d0e86afcee9897fbc50eb62aa..b774de42a21e6def4949c2568b94fab53cc566a2 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -132,7 +132,13 @@ class PageCycler(page_measurement.PageMeasurement):

results.AddValue(scalar.ScalarValue(

results.current_page, '%stimes.page_load_time' % chart_name_prefix,

- 'ms', tab.EvaluateJavaScript('__pc_load_time')))

+ 'ms', tab.EvaluateJavaScript('__pc_load_time'),

+ description='Average page load time. Measured from '

+ 'performance.timing.navigationStart until the completion '

+ 'time of a layout after the window.load event. Cold times '

+ 'are the times when the page is loaded cold, i.e. without '

+ 'loading it before, and warm times are times when the '

+ 'page is loaded after being loaded previously.'))

self._has_loaded_page[page.url] += 1