Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: chrome/browser/ui/cocoa/presentation_mode_controller.h

Issue 390503003: Enables permission bubbles to remain visible during fulscreen on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/presentation_mode_controller.h
diff --git a/chrome/browser/ui/cocoa/presentation_mode_controller.h b/chrome/browser/ui/cocoa/presentation_mode_controller.h
index 8af03b4ac7784f5e92061e8ea456c25e956b3c7b..e564f635c76d18ee5589fea9fd631db41b222f10 100644
--- a/chrome/browser/ui/cocoa/presentation_mode_controller.h
+++ b/chrome/browser/ui/cocoa/presentation_mode_controller.h
@@ -40,6 +40,10 @@
// Whether or not we are in presentation mode.
BOOL inPresentationMode_;
+ // YES if the floating dropdown bar should remain visible. When YES, disables
+ // the mouse tracking and all timers.
+ BOOL alwaysShowDropdown_;
Robert Sesek 2014/07/14 14:13:32 Have you looked at -[BrowserWindowController lockB
leng 2014/07/14 18:17:24 I did, early on during my investigation. I though
Robert Sesek 2014/07/14 20:22:31 I'd prefer to not add a flag just for the sake of
leng 2014/07/14 21:28:32 I don't think so, but don't feel that strongly abo
+
// The tracking area associated with the floating dropdown bar. This tracking
// area is attached to |contentView_|, because when the dropdown is completely
// hidden, we still need to keep a 1px tall tracking area visible. Attaching
@@ -74,6 +78,7 @@
}
@property(readonly, nonatomic) BOOL inPresentationMode;
+@property(readwrite, nonatomic) BOOL alwaysShowDropdown;
// Designated initializer.
- (id)initWithBrowserController:(BrowserWindowController*)controller;

Powered by Google App Engine
This is Rietveld 408576698