chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h - Issue 390503003: Enables permission bubbles to remain visible during fulscreen on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

Issue 390503003: Enables permission bubbles to remain visible during fulscreen on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/presentation_mode_controller.h ('K') | « chrome/browser/ui/cocoa/presentation_mode_controller.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

index e063fc8f82640286c025c26ff417ff4f858b49c3..d8a7c0b1e9c56dc6d83a43067d201c12799e27d7 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

@@ -27,13 +27,21 @@ class PermissionBubbleCocoa : public PermissionBubbleView {

const std::vector<bool>& accept_state,

bool customization_mode) OVERRIDE;

virtual void Hide() OVERRIDE;

+ virtual bool IsVisible() OVERRIDE;

virtual void SetDelegate(Delegate* delegate) OVERRIDE;

virtual bool CanAcceptRequestUpdate() OVERRIDE;

// Called when |bubbleController_| is closing.

void OnBubbleClosing();

- private:

+ // Returns the point, in screen coordinates, to which the bubble's arrow

+ // should point.

+ NSPoint AnchorPoint();

Robert Sesek 2014/07/14 14:13:32 naming: GetAnchorPoint()

leng 2014/07/14 18:17:24 Done.

+ // Returns the NSWindow containing the bubble.

+ NSWindow* window();

+private:

NSWindow* parent_window_; // Weak.

Delegate* delegate_; // Weak.