Enables permission bubbles to remain visible during fulscreen on Mac.

chrome/browser/ui/cocoa/presentation_mode_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_PRESENTATION_MODE_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_PRESENTATION_MODE_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/mac_util.h"
@@ skipping 22 matching lines @@
   // The content view for the window.  This is nil when not in presentation
   // mode.
   NSView* contentView_;  // weak
 
   // YES while this controller is in the process of entering presentation mode.
   BOOL enteringPresentationMode_;
 
   // Whether or not we are in presentation mode.
   BOOL inPresentationMode_;
 
+  // YES if the floating dropdown bar should remain visible.  When YES, disables
+  // the mouse tracking and all timers.
+  BOOL alwaysShowDropdown_;

[Robert Sesek, 2014/07/14 14:13:32]

Have you looked at -[BrowserWindowController
lockBarVisibilityForOwner:withAnimation:delay:] instead?

[leng, 2014/07/14 18:17:24]

I did, early on during my investigation.  I thought it just didn't work.  It
turns out, there was a rogue call to -ensureOverlayHiddenWithAnimation:...  I've
now fixed that.  It still won't work if there are other rogue calls to either of
the -ensureOverlay* functions, but at least the locking mechanism allows
multiple locks.

alwaysShowDropDown_ is removed, though what would you think about adding a flag
set by the browserWindowController's lock methods that this class could DCHECK? 
It might catch other rogue calls to -ensureOverlay*.

[Robert Sesek, 2014/07/14 20:22:31]

I'd prefer to not add a flag just for the sake of DCHECKing. Is there not enough
state that could be exposed by BrowserWindowController/Private to serve the same
purpose?

[leng, 2014/07/14 21:28:32]

I don't think so, but don't feel that strongly about it.

+
   // The tracking area associated with the floating dropdown bar.  This tracking
   // area is attached to |contentView_|, because when the dropdown is completely
   // hidden, we still need to keep a 1px tall tracking area visible.  Attaching
   // to the content view allows us to do this.  |trackingArea_| can be nil if
   // not in presentation mode or during animations.
   base::scoped_nsobject<NSTrackingArea> trackingArea_;
 
   // Pointer to the currently running animation.  Is nil if no animation is
   // running.
   base::scoped_nsobject<DropdownAnimation> currentAnimation_;
@@ skipping 14 matching lines @@
   // hidden, and |kFullScreenModeHideDock| while the overlay is shown.  If the
   // window is not on the primary screen, this should always be
   // |kFullScreenModeNormal|.  This value can get out of sync with the correct
   // state if we miss a notification (which can happen when a window is closed).
   // Used to track the current state and make sure we properly restore the menu
   // bar when this controller is destroyed.
   base::mac::FullScreenMode systemFullscreenMode_;
 }
 
 @property(readonly, nonatomic) BOOL inPresentationMode;
+@property(readwrite, nonatomic) BOOL alwaysShowDropdown;
 
 // Designated initializer.
 - (id)initWithBrowserController:(BrowserWindowController*)controller;
 
 // Informs the controller that the browser has entered or exited presentation
 // mode. |-enterPresentationModeForContentView:showDropdown:| should be called
 // after the window is setup, just before it is shown. |-exitPresentationMode|
 // should be called before any views are moved back to the non-fullscreen
 // window.  If |-enterPresentationModeForContentView:showDropdown:| is called,
 // it must be balanced with a call to |-exitPresentationMode| before the
@@ skipping 27 matching lines @@
 // effects, such as modifying the system fullscreen mode (menu bar shown state).
 - (void)changeFloatingBarShownFraction:(CGFloat)fraction;
 
 @end
 
 // Notification posted when we're about to enter or leave fullscreen.
 extern NSString* const kWillEnterFullscreenNotification;
 extern NSString* const kWillLeaveFullscreenNotification;
 
 #endif  // CHROME_BROWSER_UI_COCOA_PRESENTATION_MODE_CONTROLLER_H_