Enables permission bubbles to remain visible during fulscreen on Mac.

chrome/browser/ui/cocoa/presentation_mode_controller.h

Index: chrome/browser/ui/cocoa/presentation_mode_controller.h
diff --git a/chrome/browser/ui/cocoa/presentation_mode_controller.h b/chrome/browser/ui/cocoa/presentation_mode_controller.h
index 8af03b4ac7784f5e92061e8ea456c25e956b3c7b..e564f635c76d18ee5589fea9fd631db41b222f10 100644
--- a/chrome/browser/ui/cocoa/presentation_mode_controller.h
+++ b/chrome/browser/ui/cocoa/presentation_mode_controller.h
@@ -40,6 +40,10 @@
   // Whether or not we are in presentation mode.
   BOOL inPresentationMode_;
 
+  // YES if the floating dropdown bar should remain visible.  When YES, disables
+  // the mouse tracking and all timers.
+  BOOL alwaysShowDropdown_;

[Robert Sesek, 2014/07/14 14:13:32]

Have you looked at -[BrowserWindowController
lockBarVisibilityForOwner:withAnimation:delay:] instead?

[leng, 2014/07/14 18:17:24]

I did, early on during my investigation.  I thought it just didn't work.  It
turns out, there was a rogue call to -ensureOverlayHiddenWithAnimation:...  I've
now fixed that.  It still won't work if there are other rogue calls to either of
the -ensureOverlay* functions, but at least the locking mechanism allows
multiple locks.

alwaysShowDropDown_ is removed, though what would you think about adding a flag
set by the browserWindowController's lock methods that this class could DCHECK? 
It might catch other rogue calls to -ensureOverlay*.

[Robert Sesek, 2014/07/14 20:22:31]

I'd prefer to not add a flag just for the sake of DCHECKing. Is there not enough
state that could be exposed by BrowserWindowController/Private to serve the same
purpose?

[leng, 2014/07/14 21:28:32]

I don't think so, but don't feel that strongly about it.

+
   // The tracking area associated with the floating dropdown bar.  This tracking
   // area is attached to |contentView_|, because when the dropdown is completely
   // hidden, we still need to keep a 1px tall tracking area visible.  Attaching
@@ -74,6 +78,7 @@
 }
 
 @property(readonly, nonatomic) BOOL inPresentationMode;
+@property(readwrite, nonatomic) BOOL alwaysShowDropdown;
 
 // Designated initializer.
 - (id)initWithBrowserController:(BrowserWindowController*)controller;