Use street address collapser instead of line separator.

Use street address collapser instead of line separator.

Use GetStreetAddressLinesAsSingleLine() instead of
GetLineSeparatorForLanguage() in personal_data_manager.cc, because the
separator should be used to concatenate only parts of the address, of
which only the street address is multi-line.

BUG=393584
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283122

[please use gerrit instead, 2014-07-14 16:37:11]

Evan: PTAL.

[Evan Stade, 2014-07-14 17:47:40]

https://codereview.chromium.org/390083003/diff/40001/components/autofill/core...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/390083003/diff/40001/components/autofill/core...
components/autofill/core/browser/personal_data_manager.cc:574:
profile->GetMultiInfo(type, app_locale_, &multi_values);
I don't really see a huge advantage to this CL, but if you're going to do it, I
think overwriting multi_values is a bit confusing. Instead you could:

if (field == STREET_ADDRESS) {
  [...]
  multi_values.push_back(line);
} else {
  profile->GetMultiInfo(type, app_locale_, &multi_values);
}

[please use gerrit instead, 2014-07-14 19:07:09]

The advantage for this CL is to hide the concept of line separators from the
upstream libaddressinput API. This reduces their API surface and, in turn,
improves maintainability for them.

https://codereview.chromium.org/390083003/diff/40001/components/autofill/core...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/390083003/diff/40001/components/autofill/core...
components/autofill/core/browser/personal_data_manager.cc:574:
profile->GetMultiInfo(type, app_locale_, &multi_values);
On 2014/07/14 17:47:40, Evan Stade wrote:
> I don't really see a huge advantage to this CL, but if you're going to do it,
I
> think overwriting multi_values is a bit confusing. Instead you could:
> 
> if (field == STREET_ADDRESS) {
>   [...]
>   multi_values.push_back(line);
> } else {
>   profile->GetMultiInfo(type, app_locale_, &multi_values);
> }

Done.

[Evan Stade, 2014-07-14 21:20:08]

lgtm

[please use gerrit instead, 2014-07-14 22:52:49]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-07-14 22:54:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rouslan@chromium.org/390083003/60001

[commit-bot: I haz the power, 2014-07-15 01:11:37]

Change committed as 283122