Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6668)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 390083003: Use street address collapser instead of line separator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_i18n_input.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index fc0e79848af47591165b5d27eb7a6f429c165143..f235881990ab9509c38c0525850a2cf3035f70e6 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -2002,15 +2002,14 @@ ValidityMessages AutofillDialogControllerImpl::InputsAreValid(
localization.SetGetter(l10n_util::GetStringUTF8);
FieldProblemMap problems;
status = GetValidator()->ValidateAddress(*address_data, NULL, &problems);
- common::AddressType address_type = section == SECTION_SHIPPING ?
- common::ADDRESS_TYPE_SHIPPING : common::ADDRESS_TYPE_BILLING;
+ bool billing = section != SECTION_SHIPPING;
for (FieldProblemMap::const_iterator iter = problems.begin();
iter != problems.end(); ++iter) {
bool sure = iter->second != MISSING_REQUIRED_FIELD;
base::string16 text = base::UTF8ToUTF16(localization.GetErrorMessage(
*address_data, iter->first, iter->second, true, false));
- messages.Set(i18ninput::TypeForField(iter->first, address_type),
+ messages.Set(i18n::TypeForField(iter->first, billing),
ValidityMessage(text, sure));
}
}
@@ -3400,7 +3399,7 @@ void AutofillDialogControllerImpl::GetI18nValidatorSuggestions(
std::vector<base::string16>* popup_labels,
std::vector<base::string16>* popup_icons) {
AddressField focused_field;
- if (!i18ninput::FieldForType(type, &focused_field))
+ if (!i18n::FieldForType(type, &focused_field))
return;
FieldValueMap inputs;
« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_i18n_input.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698