chromeos/dbus/shill_manager_client_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_manager_client_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tweaks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_manager_client_unittest.cc

diff --git a/chromeos/dbus/shill_manager_client_unittest.cc b/chromeos/dbus/shill_manager_client_unittest.cc

index 7559b7b11e8fb42ca0eec27da2d24e2b4578b20c..cca19ccdfef69c24ea512f0072e8213c65b7f57a 100644

--- a/chromeos/dbus/shill_manager_client_unittest.cc

+++ b/chromeos/dbus/shill_manager_client_unittest.cc

@@ -165,7 +165,7 @@ TEST_F(ShillManagerClientTest, GetNetworksForGeolocation) {

base::DictionaryValue* property_dict_value = new base::DictionaryValue;

property_dict_value->SetWithoutPathExpansion(

shill::kGeoMacAddressProperty,

- base::Value::CreateStringValue("01:23:45:67:89:AB"));

+ new base::StringValue("01:23:45:67:89:AB"));

type_entry_value->Append(property_dict_value);

type_dict_value.SetWithoutPathExpansion("wifi", type_entry_value);