Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chromeos/dbus/shill_profile_client_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_profile_client_unittest.cc
diff --git a/chromeos/dbus/shill_profile_client_unittest.cc b/chromeos/dbus/shill_profile_client_unittest.cc
index d82636bd8943854b82281b0d23b2901d0fbe360d..c015bfa52a881d0b71a286d1bcc665f87feff7d1 100644
--- a/chromeos/dbus/shill_profile_client_unittest.cc
+++ b/chromeos/dbus/shill_profile_client_unittest.cc
@@ -66,7 +66,7 @@ TEST_F(ShillProfileClientTest, PropertyChanged) {
// Set expectations.
base::ListValue value;
- value.Append(base::Value::CreateStringValue(kExampleEntryPath));
+ value.Append(new base::StringValue(kExampleEntryPath));
MockPropertyChangeObserver observer;
EXPECT_CALL(observer,
OnPropertyChanged(
@@ -108,7 +108,7 @@ TEST_F(ShillProfileClientTest, GetProperties) {
// Create the expected value.
base::ListValue* entries = new base::ListValue;
- entries->Append(base::Value::CreateStringValue(kExampleEntryPath));
+ entries->Append(new base::StringValue(kExampleEntryPath));
base::DictionaryValue value;
value.SetWithoutPathExpansion(shill::kEntriesProperty, entries);
// Set expectations.
@@ -142,9 +142,8 @@ TEST_F(ShillProfileClientTest, GetEntry) {
// Create the expected value.
base::DictionaryValue value;
- value.SetWithoutPathExpansion(
- shill::kTypeProperty,
- base::Value::CreateStringValue(shill::kTypeWifi));
+ value.SetWithoutPathExpansion(shill::kTypeProperty,
+ new base::StringValue(shill::kTypeWifi));
// Set expectations.
PrepareForMethodCall(shill::kGetEntryFunction,
base::Bind(&ExpectStringArgument, kExampleEntryPath),

Powered by Google App Engine
This is Rietveld 408576698