chromeos/dbus/shill_ipconfig_client_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_ipconfig_client_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tweaks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_ipconfig_client_unittest.cc

diff --git a/chromeos/dbus/shill_ipconfig_client_unittest.cc b/chromeos/dbus/shill_ipconfig_client_unittest.cc

index 603ca2608698f43138888918958e712451b2cae0..6e8d5043cc389cab38b077b0c9babf2af73f336d 100644

--- a/chromeos/dbus/shill_ipconfig_client_unittest.cc

+++ b/chromeos/dbus/shill_ipconfig_client_unittest.cc

@@ -105,7 +105,7 @@ TEST_F(ShillIPConfigClientTest, GetProperties) {

// Create the expected value.

base::DictionaryValue value;

value.SetWithoutPathExpansion(shill::kAddressProperty,

- base::Value::CreateStringValue(kAddress));

+ new base::StringValue(kAddress));

value.SetWithoutPathExpansion(shill::kMtuProperty,

base::Value::CreateIntegerValue(kMtu));