Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chromeos/dbus/shill_client_unittest_base.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_client_unittest_base.cc
diff --git a/chromeos/dbus/shill_client_unittest_base.cc b/chromeos/dbus/shill_client_unittest_base.cc
index f53586f045f7a751ad2dc7cc1a31ff74fc002afb..bcbc14c8667d50a9cc5ead50b96da8df767eab14 100644
--- a/chromeos/dbus/shill_client_unittest_base.cc
+++ b/chromeos/dbus/shill_client_unittest_base.cc
@@ -38,7 +38,7 @@ base::DictionaryValue* PopStringToStringDictionary(
!entry_reader.PopString(&key) ||
!entry_reader.PopString(&value))
return NULL;
- result->SetWithoutPathExpansion(key, base::Value::CreateStringValue(value));
+ result->SetWithoutPathExpansion(key, new base::StringValue(value));
}
return result.release();
}
@@ -282,17 +282,14 @@ ShillClientUnittestBase::CreateExampleServiceProperties() {
base::DictionaryValue* properties = new base::DictionaryValue;
properties->SetWithoutPathExpansion(
shill::kGuidProperty,
- base::Value::CreateStringValue("00000000-0000-0000-0000-000000000000"));
+ new base::StringValue("00000000-0000-0000-0000-000000000000"));
properties->SetWithoutPathExpansion(
- shill::kModeProperty,
- base::Value::CreateStringValue(shill::kModeManaged));
- properties->SetWithoutPathExpansion(
- shill::kTypeProperty,
- base::Value::CreateStringValue(shill::kTypeWifi));
+ shill::kModeProperty, new base::StringValue(shill::kModeManaged));
+ properties->SetWithoutPathExpansion(shill::kTypeProperty,
+ new base::StringValue(shill::kTypeWifi));
shill_property_util::SetSSID("testssid", properties);
properties->SetWithoutPathExpansion(
- shill::kSecurityProperty,
- base::Value::CreateStringValue(shill::kSecurityPsk));
+ shill::kSecurityProperty, new base::StringValue(shill::kSecurityPsk));
return properties;
}

Powered by Google App Engine
This is Rietveld 408576698