Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chromeos/dbus/gsm_sms_client_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/gsm_sms_client_unittest.cc
diff --git a/chromeos/dbus/gsm_sms_client_unittest.cc b/chromeos/dbus/gsm_sms_client_unittest.cc
index babe0edf847472b1f813e5e6be6e446f10e44223..5582e9b547b00519497a741d2c81659ad90e2114 100644
--- a/chromeos/dbus/gsm_sms_client_unittest.cc
+++ b/chromeos/dbus/gsm_sms_client_unittest.cc
@@ -267,9 +267,9 @@ TEST_F(GsmSMSClientTest, Get) {
// Create expected result.
base::DictionaryValue expected_result;
expected_result.SetWithoutPathExpansion(
- kNumberKey, base::Value::CreateStringValue(kExampleNumber));
- expected_result.SetWithoutPathExpansion(
- kTextKey, base::Value::CreateStringValue(kExampleText));
+ kNumberKey, new base::StringValue(kExampleNumber));
+ expected_result.SetWithoutPathExpansion(kTextKey,
+ new base::StringValue(kExampleText));
expected_result_ = &expected_result;
// Call Delete.
client_->Get(kServiceName, dbus::ObjectPath(kObjectPath), kIndex,
@@ -308,10 +308,9 @@ TEST_F(GsmSMSClientTest, List) {
// Create expected result.
base::ListValue expected_result;
base::DictionaryValue* sms = new base::DictionaryValue;
- sms->SetWithoutPathExpansion(
- kNumberKey, base::Value::CreateStringValue(kExampleNumber));
- sms->SetWithoutPathExpansion(
- kTextKey, base::Value::CreateStringValue(kExampleText));
+ sms->SetWithoutPathExpansion(kNumberKey,
+ new base::StringValue(kExampleNumber));
+ sms->SetWithoutPathExpansion(kTextKey, new base::StringValue(kExampleText));
expected_result.Append(sms);
expected_result_ = &expected_result;
// Call List.

Powered by Google App Engine
This is Rietveld 408576698