chrome/test/chromedriver/alert_commands.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/alert_commands.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/alert_commands.cc

diff --git a/chrome/test/chromedriver/alert_commands.cc b/chrome/test/chromedriver/alert_commands.cc

index 199e7bc4515bf1dc1e5b2035aa1ad6458294528f..f75e440a5109d21fa5a27165bce7e6ca1045c221 100644

--- a/chrome/test/chromedriver/alert_commands.cc

+++ b/chrome/test/chromedriver/alert_commands.cc

@@ -59,7 +59,7 @@ Status ExecuteGetAlertText(

web_view->GetJavaScriptDialogManager()->GetDialogMessage(&message);

if (status.IsError())

return status;

- value->reset(base::Value::CreateStringValue(message));

+ value->reset(new base::StringValue(message));

return Status(kOk);

}