Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 388203002: Remove listener_ from AutocompleteProvider base class (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Project:
chromium
Visibility:
Public.

Description

Remove listener_ from AutocompleteProvider base class Only a few provider implementations need this member. BUG=None TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -76 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.h View 4 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/base_search_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 3 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
6 years, 5 months ago (2014-07-14 11:48:54 UTC) #1
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-14 21:38:54 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-15 00:17:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/388203002/1
6 years, 5 months ago (2014-07-15 00:19:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 16:49:32 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 23:56:57 UTC) #6
Message was sent while issue was closed. 
Change committed as 283280

Powered by Google App Engine
This is Rietveld 408576698