Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3219)

Unified Diff: chrome/browser/autocomplete/autocomplete_provider.h

Issue 388203002: Remove listener_ from AutocompleteProvider base class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_provider.h
diff --git a/chrome/browser/autocomplete/autocomplete_provider.h b/chrome/browser/autocomplete/autocomplete_provider.h
index a5720696901728d38719e5c33b6835b82f6d86f9..4237ecb460311d97e4b3c7d7b3d38a19eed38843 100644
--- a/chrome/browser/autocomplete/autocomplete_provider.h
+++ b/chrome/browser/autocomplete/autocomplete_provider.h
@@ -12,7 +12,6 @@
#include "components/metrics/proto/omnibox_event.pb.h"
class AutocompleteInput;
-class AutocompleteProviderListener;
class BookmarkModel;
typedef std::vector<metrics::OmniboxEventProto_ProviderInfo> ProvidersInfo;
@@ -137,8 +136,7 @@ class AutocompleteProvider
TYPE_ZERO_SUGGEST = 1 << 7,
};
- AutocompleteProvider(AutocompleteProviderListener* listener,
- Type type);
+ explicit AutocompleteProvider(Type type);
// Returns a string describing a particular AutocompleteProvider type.
static const char* TypeToString(Type type);
@@ -203,11 +201,6 @@ class AutocompleteProvider
// Returns a string describing this provider's type.
const char* GetName() const;
-#ifdef UNIT_TEST
- void set_listener(AutocompleteProviderListener* listener) {
- listener_ = listener;
- }
-#endif
// A suggested upper bound for how many matches a provider should return.
// TODO(pkasting): http://b/1111299 , http://b/933133 This should go away once
// we have good relevance heuristics; the controller should handle all
@@ -248,7 +241,6 @@ class AutocompleteProvider
// return 0.
static size_t TrimHttpPrefix(base::string16* url);
- AutocompleteProviderListener* listener_;
ACMatches matches_;
bool done_;
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_controller.cc ('k') | chrome/browser/autocomplete/autocomplete_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698