Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4704)

Unified Diff: chrome/browser/autocomplete/shortcuts_provider_unittest.cc

Issue 388203002: Remove listener_ from AutocompleteProvider base class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/shortcuts_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
index 0b2945fdd6edf2a17e523119dabe5f4b4484be59..cf215bc09fca867f80a37c9ba0a932335c62a36f 100644
--- a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
+++ b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
@@ -19,7 +19,6 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/autocomplete/autocomplete_match.h"
#include "chrome/browser/autocomplete/autocomplete_provider.h"
-#include "chrome/browser/autocomplete/autocomplete_provider_listener.h"
#include "chrome/browser/autocomplete/autocomplete_result.h"
#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
#include "chrome/browser/autocomplete/shortcuts_backend.h"
@@ -236,14 +235,10 @@ ACMatchClassifications ClassifyTest::RunTest(const base::string16& find_text) {
// ShortcutsProviderTest ------------------------------------------------------
-class ShortcutsProviderTest : public testing::Test,
- public AutocompleteProviderListener {
+class ShortcutsProviderTest : public testing::Test {
public:
ShortcutsProviderTest();
- // AutocompleteProviderListener:
- virtual void OnProviderUpdate(bool updated_matches) OVERRIDE;
-
protected:
typedef std::pair<std::string, bool> ExpectedURLAndAllowedToBeDefault;
typedef std::vector<ExpectedURLAndAllowedToBeDefault> ExpectedURLs;
@@ -303,15 +298,13 @@ ShortcutsProviderTest::ShortcutsProviderTest()
file_thread_(content::BrowserThread::FILE, &message_loop_) {
}
-void ShortcutsProviderTest::OnProviderUpdate(bool updated_matches) {}
-
void ShortcutsProviderTest::SetUp() {
ShortcutsBackendFactory::GetInstance()->SetTestingFactoryAndUse(
&profile_, &ShortcutsBackendFactory::BuildProfileNoDatabaseForTesting);
backend_ = ShortcutsBackendFactory::GetForProfile(&profile_);
ASSERT_TRUE(backend_.get());
ASSERT_TRUE(profile_.CreateHistoryService(true, false));
- provider_ = new ShortcutsProvider(this, &profile_);
+ provider_ = new ShortcutsProvider(&profile_);
FillData(shortcut_test_db, arraysize(shortcut_test_db));
}
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698