Chromium Code Reviews Chromium Code Reviews
Issue
387663003:
Improve GN handling of directory templates. (Closed)
DescriptionImprove GN handling of directory templates.
The previous implementation of the directory-based file templates (like {{source_out_dir}}}) was overly simplistic. It did not allow these templates to be used in the outputs section of a target since the directories were relative to the build directory (it was only useful for actions).
This new implementation changes the expansion of these values depending on where they're used, so they can be absolute when used in the outputs section, but relative to the build directory when used in the args section.
The implementation of outputs was changed to allow the use of these expansions. The previous implementation stored them as SourceFiles which didn't allow the use of directory expansions, since that happens after converting the input to a SourceFile. This new patch stores the outputs as a list of strings to allow this to be late-bound properly (and it turns out that almost all users of this wanted the strings anyway).
Changes the function that checks that files are in the output directory to optionally handle templates. Adds a test for this function.
Fixes a bug in get_target_outputs that it didn't work for copy() targets that contained templates. Fix this and add a test.
BUG=
R=viettrungluu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282639
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
