Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: tools/gn/ninja_copy_target_writer_unittest.cc

Issue 387663003: Improve GN handling of directory templates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_copy_target_writer.cc ('k') | tools/gn/ninja_target_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_copy_target_writer_unittest.cc
diff --git a/tools/gn/ninja_copy_target_writer_unittest.cc b/tools/gn/ninja_copy_target_writer_unittest.cc
index 0b1618e15e58164ae750a90b7c80da3f0ca66ef9..e9f24371ba27db5c35399d25c7b6ff17076b4c04 100644
--- a/tools/gn/ninja_copy_target_writer_unittest.cc
+++ b/tools/gn/ninja_copy_target_writer_unittest.cc
@@ -22,7 +22,7 @@ TEST(NinjaCopyTargetWriter, Run) {
target.sources().push_back(SourceFile("//foo/input2.txt"));
target.action_values().outputs().push_back(
- SourceFile("//out/Debug/{{source_name_part}}.out"));
+ "//out/Debug/{{source_name_part}}.out");
std::ostringstream out;
NinjaCopyTargetWriter writer(&target, setup.toolchain(), out);
@@ -56,8 +56,7 @@ TEST(NinjaCopyTargetWriter, ToolchainDeps) {
target.sources().push_back(SourceFile("//foo/input1.txt"));
- target.action_values().outputs().push_back(
- SourceFile("//out/Debug/output.out"));
+ target.action_values().outputs().push_back("//out/Debug/output.out");
std::ostringstream out;
NinjaCopyTargetWriter writer(&target, setup.toolchain(), out);
« no previous file with comments | « tools/gn/ninja_copy_target_writer.cc ('k') | tools/gn/ninja_target_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698